https://github.com/chendaniely/2023-01-15-mds-pr

Science Score: 26.0%

This score indicates how likely this project is to be science-related based on various indicators:

○
CITATION.cff file
✓
codemeta.json file
Found codemeta.json file
✓
.zenodo.json file
Found .zenodo.json file
○
DOI references
○
Academic publication links
○
Academic email domains
○
Institutional organization owner
○
JOSS paper metadata
○
Scientific vocabulary similarity
Low similarity (10.5%) to scientific vocabulary

Last synced: 10 months ago · JSON representation

Repository

Basic Info

Host: GitHub
Owner: chendaniely
Default Branch: master
Size: 2.93 KB

Statistics

Stars: 0
Watchers: 2
Forks: 0
Open Issues: 1
Releases: 0

Created over 3 years ago · Last pushed over 3 years ago

Metadata Files

Readme

README.md

Review my pull request

A GitHub repository that serves the purpose of learning how use GitHub's code review feature for pull requests.

Usage

Click the green "Use this template" button in this repository to obtain a copy of it for yourself (do not fork it).
Go to Repository Settings > Actions > General > under "Workflow permissions" make sure read and write permissions are enabled and also GitHub Actions is able to create and approve Pull Requests
Create a remote branch named pr (this will use GitHub Actions to create a pull request for you to review in this repository).
Click on the Pull Requests tab of your copy of the repository, click on the pull request titled "Report most accomplished pilots", and then click on "Files Changed". Next click on the star-wars.Rmd file. Review the file and observe the following problems with the R Markdown report that was submitted via the pull request:
Reasoning of the sentence on line 15
Incompatibility with the sentence on line 15 with the code in the code chunk named table-of-most-accomplished-pilots
Incorrect code in code chunk named table-of-most-accomplished-pilots (unested film instead of starships) leads to naming the wrong pilot as the most accomplished pilot on line 27
Incorrect code in code chunk named table-of-most-accomplished-pilots (unested film instead of starships) leads to the use of the wrong character's picture in the image that is sourced in the code chunk named top-pilot (it should be a picture of Obi-Wan Kenobi, you could use this URL for example: https://hips.hearstapps.com/hmg-prod.s3.amazonaws.com/images/ewan-mcgregor-obi-wan-1570898048.jpg).
Add comments and suggested changes using the + sign beside the line numbers (the first time you do this will trigger the start of your code review. Need help? See GitHub's how to on reviewing proposed changes in a pull request.
After you have made all the comments and suggested changes, then add a general comment for the code review, select "Request Changes" and submit your code review.
Practice accepting code changes that you provided as suggestions by revisiting the Pull Requests tab of your copy of the repository and clicking on the pull request titled "Report most accomplished pilots". Scroll through the pull request comments and find the code suggestions. Then click on the "Commit suggestion button" for each suggestion.
Click on the "Show all reviewers" link beside the red "Changes requested"" text. Then click on the ... beside the reviewer and click "Approve changes".
Finally click on the green buttons ("Merge Pull Request" & "Confirm merge") to merge the pull request.

Owner

Name: Daniel Chen
Login: chendaniely
Kind: user
Location: JFK -> DCA -> ROA -> JFK -> YVR
Company: @rstudio @UBC-DSCI @UBC-MDS

Website: http://chendaniely.github.io
Twitter: chendaniely
Repositories: 460
Profile: https://github.com/chendaniely

bow ties are cool

GitHub Events

Total

Last Year

Issues and Pull Requests

Last synced: 11 months ago

All Time

Total issues: 0
Total pull requests: 1
Average time to close issues: N/A
Average time to close pull requests: N/A
Total issue authors: 0
Total pull request authors: 1
Average comments per issue: 0
Average comments per pull request: 0.0
Merged pull requests: 0
Bot issues: 0
Bot pull requests: 1

Past Year

Issues: 0
Pull requests: 0
Average time to close issues: N/A
Average time to close pull requests: N/A
Issue authors: 0
Pull request authors: 0
Average comments per issue: 0
Average comments per pull request: 0
Merged pull requests: 0
Bot issues: 0
Bot pull requests: 0

ecosyste.ms

Data

Tools

Indexes

Applications

Experiments

Open Source Science