SWE-bench Instance: django__django-11001

Repository: django/django Base Commit: ef082ebb84f00e38af4e8880d04e8365c2766d34

Problem Statement

Incorrect removal of order_by clause created as multiline RawSQL Description

Hi. The SQLCompiler is ripping off one of my "order by" clause, because he "thinks" the clause was already "seen" (in SQLCompiler.getorderby()). I'm using expressions written as multiline RawSQLs, which are similar but not the same. The bug is located in SQLCompiler.getorderby(), somewhere around line computing part of SQL query without ordering: withoutordering = self.orderingparts.search(sql).group(1) The sql variable contains multiline sql. As a result, the self.orderingparts regular expression is returning just a line containing ASC or DESC words. This line is added to seen set, and because my raw queries have identical last lines, only the first clasue is returing from SQLCompiler.getorderby(). As a quick/temporal fix I can suggest making sql variable clean of newline characters, like this: sqloneline = ' '.join(sql.split('\n')) withoutordering = self.orderingparts.search(sqloneline).group(1) Note: beware of unicode (Py2.x u'') and EOL dragons (\r). Example of my query: return MyModel.objects.all().orderby( RawSQL(''' case when status in ('accepted', 'verification') then 2 else 1 end''', []).desc(), RawSQL(''' case when status in ('accepted', 'verification') then (accepteddatetime, preferreddatetime) else null end''', []).asc(), RawSQL(''' case when status not in ('accepted', 'verification') then (accepteddatetime, preferreddatetime, createdat) else null end''', []).desc()) The orderingparts.search is returing accordingly: ' then 2 else 1 end)' ' else null end' ' else null end' Second RawSQL with a else null end part is removed from query. The fun thing is that the issue can be solved by workaround by adding a space or any other char to the last line. So in case of RawSQL I can just say, that current implementation of avoiding duplicates in order by clause works only for special/rare cases (or does not work in all cases). The bug filed here is about wrong identification of duplicates (because it compares only last line of SQL passed to order by clause). Hope my notes will help you fixing the issue. Sorry for my english.

Repository Contents

This repository contains the actual source code from the original repository at commit ef082ebb84f00e38af4e8880d04e8365c2766d34. The code is ready for development and testing.

Docker Environment

A Dockerfile is provided to set up the proper environment for this instance:

bash docker build -t swebench-instance . docker run -it swebench-instance /bin/bash