https://github.com/converged-computing/nfd-source - nfd-source release testing v0.0.2

What's Changed

• slog: error logging should be Any to allow err by @vsoch in https://github.com/converged-computing/nfd-source/pull/2

Full Changelog: https://github.com/converged-computing/nfd-source/compare/0.0.1...0.0.2

- Go
Published by vsoch over 2 years ago

https://github.com/converged-computing/nfd-source - nfd-source release testing v0.0.1

This release removes the test data for pci, which can be added back later.

What's Changed

• test install removing test data by @vsoch in https://github.com/converged-computing/nfd-source/pull/1

New Contributors

• @vsoch made their first contribution in https://github.com/converged-computing/nfd-source/pull/1

Full Changelog: https://github.com/converged-computing/nfd-source/compare/0.0.0...0.0.1

- Go
Published by vsoch over 2 years ago

https://github.com/converged-computing/nfd-source - nfd-source release testing v0.0.0

This is primarily a test for installing.

Changes

I made the following changes to cleanly separate the Kubernetes logic from the source logic.

• pkg/apis/nfd/v1alpha1/types.go
  • The need for corev1 in types.go is only because of Taints, which I don't see anywhere in source so I'm removing.
  • metav1 is to add object metadata (also for Kubernetes) so I will remove that for now.
  • The protocol buffers would also be for gRPC, which is a specific use case not necessary for underlying source.
  • It looks like we don't actually need NodeFeature, NodeFeatureSpec, NodeFeatureList, NodeFeatureRule (these are higher level in the logic)
  • The entire namespace of Rule/Match is oriented to custom, which also seems like it belongs in the upstream
  • I'm keeping the same path for now to maintain git history
  • When we remove the above, the interface is very simple!
• pkg/apis/nfd/v1alpha1/register.go
  • Is primarily for K8s schemas, etc. can be removed.
• pkg/apis/nfd/v1alpha1/feature.go
  • MergeInto functions are not used, as aren't the Node specific ones.
• pkg/apis/nfd/v1alpha1/nodefeaturerule
  • Also does not seem used in source
• pkg/utils/flags.go also not used
• pkg/utils/memory_resources.go (and test) are not used in source, this is again for K8s
• pkg/utils/(klog|kubeconf|grpc_log.go|metrics.go|tls.go) are kubernetes specific, also removing, and kubernetes.go
• klog is replaced with "slog" which is part of go as of 1.21

Full Changelog: https://github.com/converged-computing/nfd-source/commits/0.0.0

- Go
Published by vsoch over 2 years ago